treewide: appease clippy and the deprecation warnings #805
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Very recently, a new version of `chrono` have been released (`0.4.27`) which deprecates the `DateTime::from_utc` function. As we treat deprecation warnings as errors, this started to cause the CI to fail. This commit replaces the use of this function with `DateTime::from_naive_utc_and_offset`.
Clippy started to suggest using arrays instead of `vec!` where applicable, i.e. if the vector would be converted to an iterator anyway, then we can get rid of an allocation by replacing it with an array. This is only an issue with a small number of tests and it's easy to fix, so this commit just applies clippy's suggestions.
cvybhu
approved these changes
Sep 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This time, we've got a double whammy:
clippyversion has been bumped up in GitHub's CI runner, which introduced new lints that are failing for our codebase,chronohas been released which deprecatesDateTime::from_utc.This PR addresses both of the issues, making the CI green again.
Pre-review checklist
I added relevant tests for new features and bug fixes.I have provided docstrings for the public items that I want to introduce.I have adjusted the documentation in./docs/source/.I added appropriateFixes:annotations to PR description.